FlowingCode / GridExporterAddon

Apache License 2.0
10 stars 9 forks source link

Add-on not working on Vaadin 24.4.0.alpha15 #104

Closed paodb closed 5 months ago

paodb commented 6 months ago

Latest version 2.2.1, is not working with Vaadin 24.4.0.alpha15

Browser console shows error:

image

paodb commented 6 months ago

I did more testing and it seems it all worked okay up until alpha5, the error started from alpha7 (there's no alpha6).

javier-godoy commented 6 months ago

Is that error in development mode, production mode or both? Can you try alpha5 with intermediate Flow versions (alpha10 to alpha13)? Vaadin 24.4.0.alpha5 is based on Flow 24.4.0.alpha9 while Vaadin 24.4.0.alpha7 is based in Flow 24.4.0.alpha13,

paodb commented 6 months ago

Only tried dev mode, will try the other suggestions.

paodb commented 6 months ago

I did the test, with Vaadin 24.4.0.alpha5 and flow version from 24.4.0.alpha10 to 13 (and even 14) and it did not break. Tested both dev and prod mode.

paodb commented 6 months ago

Production mode error on browser from Vaadin 24.4.0.alpha7 to alpha16:

image

sveinnetnordic commented 5 months ago

Same error in 24.4.0.alpha22 using grid-exporter-addon 2.3.1

sveinnetnordic commented 5 months ago

In file: node_modules/@flowingcode/font-awesome-iron-iconset/far.js

If I remove import '@vaadin/icon/vaadin-icon.js'; on line 25 it works.

Hope this can help you to fix this!

javier-godoy commented 5 months ago

In file: node_modules/@flowingcode/font-awesome-iron-iconset/far.js

If I remove import '@vaadin/icon/vaadin-icon.js'; on line 25 it works.

Hope this can help you to fix this!

Thanks. I'll look into it.

sveinnetnordic commented 5 months ago

Found this as a workaround:

<dependency>
            <groupId>com.flowingcode.addons</groupId>
            <artifactId>font-awesome-iron-iconset</artifactId>
            <version>5.2.2</version>
</dependency>
javier-godoy commented 5 months ago

Good catch. I hadn't realized that version 2.x of this addon (which is compatible with Vaadin 24) depends on FA 4.x (which is compatible with Vaadin 23). https://github.com/FlowingCode/GridExporterAddon/blob/3105a54ba08d23afc7ce256a4b6d6c4c54686aa9/pom.xml#L152-L154

sveinnetnordic commented 4 months ago

I hope for a new release soon!

paodb commented 4 months ago

@sveinnetnordic please check new released version 2.3.2.