Closed javier-godoy closed 1 month ago
The recent changes involve updating various classes in the gridexporter
package to shift from using input stream factories to stream resource writers. This includes renaming classes and methods, modifying method signatures, and updating logic for handling output streams. Additionally, a new dependency on jakarta.servlet-api
has been added to the pom.xml
file.
File Path | Change Summary |
---|---|
pom.xml |
Added dependency on jakarta.servlet-api version 6.0.0 with scope provided . |
.../BaseStreamResourceWriter.java |
Renamed BaseInputStreamFactory to BaseStreamResourceWriter and updated the implemented interface. |
.../CsvStreamResourceWriter.java |
Renamed class and updated methods to handle output streams directly for CSV writing. |
.../DocxStreamResourceWriter.java |
Renamed class and updated methods to handle output streams directly for DOCX writing, including session handling. |
.../ExcelStreamResourceWriter.java |
Renamed class and updated methods to handle output streams directly for Excel writing, with significant logic refactoring. |
.../GridExporter.java |
Replaced input stream factories with stream resource writers for various file formats. |
.../PdfStreamResourceWriter.java |
Renamed class and updated methods to handle output streams directly for PDF writing. |
In a code forest, changes bloom, Stream writers now assume the room. CSVs and PDFs, Excel too, Flowing streams, a fresh debut. From input streams, we now depart, Embracing output with a rabbit's heart. πΈβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Quality Gate failed
Failed conditions 1 Security Hotspot
Sonar complains about a line that was already present in the codebase https://github.com/FlowingCode/GridExporterAddon/blob/9fafac333446d04648174ca9f18274060ce4e204/src/main/java/com/flowingcode/vaadin/addons/gridexporter/PdfInputStreamFactory.java#L71
Actionable comments posted: 6
Ears twitch, hops abound, Annoying rabbit's antics, Test patience, yet charm.
ππ
Use StreamResourceWriter instead of InputStreamFactory + Thread + PipedInput/OutputStream + implicit StreamResource pipe.
Summary by CodeRabbit
New Features
Refactor