There was a call to setHeightByRows when the grid was not attached. This call was redundant since attaching the Grid would cause the height to be recomputed.
Avoid division by zero if the grid is empty.
Add Grid's own borders to the computed height (by default grid has box-sizing: border-box, and borders will be substracted from the set height)
Recompute heightByRows when the grid height is updated:
When the grid is initially attached, it has no columns and it's too early to measure rows in the browser.
When the size of the parent component is undefined, the grid may be rendered with no data. The first call to computeHeightByRows will just return header+footer, causing data to be retrieved later.
When the computed height is set, fire another call to computeHeightByRows, so that a new height is computed, avoiding sub-pixel rounding errors.
Also, add some thread sleep in order to reduce flakiness in ResponsiveGridIT.
Several fixes related to heightByRows. Close #80
There was a call to setHeightByRows when the grid was not attached. This call was redundant since attaching the Grid would cause the height to be recomputed.
Avoid division by zero if the grid is empty.
Add Grid's own borders to the computed height (by default grid has
box-sizing: border-box, and borders will be substracted from the setheight)Recompute heightByRows when the grid height is updated:
computeHeightByRowswill just return header+footer, causing data to be retrieved later.computeHeightByRows, so that a new height is computed, avoiding sub-pixel rounding errors.Also, add some thread sleep in order to reduce flakiness in ResponsiveGridIT.