search

FlowingCode / TwinColGridAddon

TwinColGrid Vaadin Add-on
https://www.flowingcode.com/en/open-source/
Apache License 2.0
7 stars 7 forks source link

addValueChangeListener always return fromClient = true #106

Closed jcgueriaud1 closed 2 years ago

jcgueriaud1 commented 2 years ago

In the code the addValueChangeListener always return isFromClient = true even if the event is coming from the server.

https://github.com/FlowingCode/TwinColGridAddon/blob/master/src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java#L765

Maybe one solution is to change the signature of the updateSelection with a new parameter isFromClient

javier-godoy commented 2 years ago

Thanks for the PR! The fix has been released in version 2.8.0