FlowingCode / TwinColGridAddon

TwinColGrid Vaadin Add-on
https://www.flowingcode.com/en/open-source/
Apache License 2.0
7 stars 7 forks source link

Refactor addFilterableColumn/addSortableColumn #116

Closed javier-godoy closed 1 year ago

javier-godoy commented 1 year ago

Consider addFilterableColumn. The API design for this method did not grew well. There are 4 overloads, but none of them allow configuring the column as resizable (#115).

addFilterableColumn(ItemLabelGenerator<T>, SerializableFunction<T, String>, String, String, boolean, String)
addFilterableColumn(ItemLabelGenerator<T>, String, String, boolean)
addFilterableColumn(ItemLabelGenerator<T>, SerializableFunction<T, String>, String, String, boolean)
addFilterableColumn(ItemLabelGenerator<T>, String, String, boolean, String key)

The same applies to addSortableColumn (in this case there are only 2 overloads, but none of them allow configuring the column as resizable):

addSortableColumn(ItemLabelGenerator<T> itemLabelGenerator, Comparator<T> comparator, String header, String key)
addSortableColumn(ItemLabelGenerator<T> itemLabelGenerator, Comparator<T> comparator, String header)
javier-godoy commented 1 year ago

Blocked by discussion in #34

javier-godoy commented 1 year ago

Move to "To Do". We agreed to work in this issue.