search

FlowingCode / TwinColGridAddon

TwinColGrid Vaadin Add-on
https://www.flowingcode.com/en/open-source/
Apache License 2.0
7 stars 7 forks source link

Wrong implementation of isReadOnly #119

Closed javier-godoy closed 1 year ago

javier-godoy commented 1 year ago

isReadOnly compares the selection model with SelectionMode.NONE, which is not a selection model. https://github.com/FlowingCode/TwinColGridAddon/blob/b489ff03f8e2b2843dbe42d4b7fc9b8632f9b20e/src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java#L839-L841

Compilation with source compatibility level 17 yields:

TwinColGrid.java:[840,51] incomparable types: 
com.vaadin.flow.component.grid.GridSelectionModel<T> and com.vaadin.flow.component.grid.Grid.SelectionMode