search

FlowingCode / TwinColGridAddon

TwinColGrid Vaadin Add-on
https://www.flowingcode.com/en/open-source/
Apache License 2.0
7 stars 7 forks source link

Add support for Lazy Data Provider #130

Open brunoagretti opened 1 year ago

brunoagretti commented 1 year ago

It'd be great if we could use lazy data providers, just like in regular grids.

javier-godoy commented 1 year ago

This requires a major refactoring (hence it's a good candidate for Version 3). The main issue is that the implementation assumes that the grid has a ListDataProvider. With a lazy data provider (in the "available" grid), the selected items would have to be filtered out, instead of removed.

javier-godoy commented 1 year ago

~I've just realized that filtering would also provide a nice solution for the scenario discussed in the linked issue (even with ListDataProvider).~ [comment retracted]

mlopezFC commented 1 year ago

One thing to take into account. Removing the items in the left grid might be impossible, so one idea would be to display them greyed out.

flang commented 1 year ago

Does it make sense to support lazy providers on selected grid? IMO only available grid should support it.

higgsja commented 1 year ago

On the surface that makes sense. Wonder if it actually matters in any way, though.

a

--

Thanks! West Point 1976 H-3 Join us! https://hlh-tx.com Mission: To measurably improve investor performance

"We enjoy the comfort of opinion without the discomfort of thought." -- J.F. Kennedy

On 2/16/23 11:37, Felipe Lang wrote:

Does it make sense to support lazy providers on selected grid? IMO only available grid should support it

— Reply to this email directly, view it on GitHub https://github.com/FlowingCode/TwinColGridAddon/issues/130#issuecomment-1433464600, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZKGI5H22VNR4UXVKAYS6DWXZQXBANCNFSM6AAAAAAUQQQ22Y. You are receiving this because you are subscribed to this thread.Message ID: @.***>

javier-godoy commented 1 year ago

Does it make sense to support lazy providers on selected grid? IMO only available grid should support it.

I agree. We can start by supporting lazy data providers on the available grid (which is already a big change), and discuss lazy providers on selected grid later. I'm not sure if there are use cases where supporting so many selected items is good UX.