search

FlowingCode / TwinColGridAddon

TwinColGrid Vaadin Add-on
https://www.flowingcode.com/en/open-source/
Apache License 2.0
7 stars 7 forks source link

feat: add support for binding set of items #173

Closed ngonzalezpazFC closed 6 months ago

ngonzalezpazFC commented 6 months ago

Add support for binding set of items Add TwinColGridSetAdapter.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

javier-godoy commented 6 months ago

TwinColGrid is already a HasValue<ValueChangeEvent<Set<T>>, Set<T>>. Why do we need an adapter?

https://github.com/FlowingCode/TwinColGridAddon/blob/8b3326eb03b5be1f2070cc5f17242bf46b39bd33/src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java#L80-L81

mlopezFC commented 6 months ago

We can close this PR given that what is needed is already supported.