FlowingCode / TwinColGridAddon

TwinColGrid Vaadin Add-on
https://www.flowingcode.com/en/open-source/
Apache License 2.0
7 stars 7 forks source link

Infinite Loop on set required indicator visible true #86

Closed ahmedmirza994 closed 2 years ago

ahmedmirza994 commented 2 years ago

at com.flowingcode.vaadin.addons.twincolgrid.TwinColGrid.setRequiredIndicatorVisible(TwinColGrid.java:614) ~[twincolgrid-2.4.0.jar:2.4.0]

I think you are missing to call super.setRequiredIndicatorVisible(value) inside your override method setRequiredIndicatorVisible.

javier-godoy commented 2 years ago

Thanks for the report. There is no super.setRequiredIndicatorVisible because TwinColGrid is a custom component, but you are right that it should have implemented setRequiredIndicatorVisible (and isRequiredIndicatorVisible, and isReadOnly) in a meaningful way.

javier-godoy commented 2 years ago

Released in v2.5.0