search

Flowminder / FlowKit-benchmarks

Benchmarks for the FlowKit project
https://flowminder.github.io/FlowKit-benchmarks
Mozilla Public License 2.0
0 stars 0 forks source link

Duplication of benchmark code #1

Open jc-harrison opened 5 years ago

jc-harrison commented 5 years ago

Currently, all of the benchmark classes in benchmarks/benchmarks.py define two identical benchmarks, and only differ in the additional parameters and the setup() function.

Ideally, we should remove this duplication (perhaps by deriving all the benchmark classes from one base class, or by passing the query kinds as parameters to a single benchmark class).

jc-harrison commented 5 years ago

I have tried defining a BaseBenchmarkSuite class, but it doesn't seem to be possible to tell asv not to run this base class as a benchmark itself.

jc-harrison commented 5 years ago

It is probably worth leaving this until we have added some more benchmarks, since we may find that we want to add benchmarks which don't follow the same pattern as the ones we have now. Also, once we have refactored QueryProxy we may find that there is a way to use that to simplify the refactoring here.

jc-harrison commented 4 years ago

The base-class branch should fix this once https://github.com/airspeed-velocity/asv/pull/828 is released.