search

Flowminder / FlowKit

FlowKit: Flowminder CDR analytics toolkit
https://flowminder.github.io/FlowKit/
Mozilla Public License 2.0
86 stars 20 forks source link

Lockfiles getting out of sync #428

Open greenape opened 5 years ago

greenape commented 5 years ago

If dependabot updates the lock file for flowmachine's Pipfile, then the lock files in integration tests and docs will be out of sync with flowmachine's. Same will happen if we add a package to one of the child project lock files.

greenape commented 5 years ago

(Can't think of any obvious way to fix that, but worth mentioning)

greenape commented 5 years ago

Possible solution - remove flowmachine etc. from the integration test and docs pipfiles, install their dependencies using bash thus:

PIPENV_PIPFILE="../flowapi/Pipfile" pipenv install --ignore-pipfile and the packages themselves so: pipenv install --skip-lock ../flowapi

Bit of a pain for running tests docs in PyCharm, because you need to make sure the install gets invoked. Doesn't protect you where an automated update updates a dependency of both, because it'll only update it in one, and the version you'd end up running the tests with will be the one from whichever was last in the script.

greenape commented 5 years ago

https://github.com/dependabot/feedback/issues/460

greenape commented 2 years ago

This by itself is a major argument in favour of migrating away from our monorepo.