Flowminder / FlowKit

FlowKit: Flowminder CDR analytics toolkit
https://flowminder.github.io/FlowKit/
Mozilla Public License 2.0
86 stars 20 forks source link

Use 'SELECT DISTINCT ON' in LastLocation #6622

Closed jc-harrison closed 1 month ago

jc-harrison commented 2 months ago

Closes #6603

I have:

Description

Rewrites the SQL for LastLocation to use SELECT DISTINCT ON instead of a window function.

greenape commented 2 months ago

Acceptance tests for generated sql need updating

cypress[bot] commented 1 month ago

Passing run #22810 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into faster-last-location
Project: FlowAuth Commit: 746c9faf28
Status: Passed Duration: 00:43 💡
Started: Jun 12, 2024 9:04 AM Ended: Jun 12, 2024 9:05 AM

Review all test suite changes for PR #6622 ↗︎

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.31%. Comparing base (582139d) to head (3acdac7).

:exclamation: Current head 3acdac7 differs from pull request most recent head 746c9fa

Please upload reports for the commit 746c9fa to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6622 +/- ## ======================================= Coverage 92.30% 92.31% ======================================= Files 268 268 Lines 10586 10586 Branches 855 855 ======================================= + Hits 9771 9772 +1 Misses 676 676 + Partials 139 138 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.