Fix slow displacement test

greenape commented 4 weeks ago

I have:

[x] Formatted any Python files with black
[x] Brought the branch up to date with master
[x] Added any relevant Github labels
[ ] Added tests for any new additions
[ ] Added or updated any relevant documentation
[ ] Added an Architectural Decision Record (ADR), if appropriate
[ ] Added an MPLv2 License Header if appropriate
[ ] Updated the Changelog

Description

Makes a couple of changes to the tests for the Displacement class, which speed up the tests substantially. Namely, storing the reused reference location, and supplying a subscriber subset.

:rocket:	This description was created by Ellipsis for commit 0df973660c18371e9a2dacb8cd73a553cda3e302

Summary:

Optimized Displacement class tests by caching reference locations and limiting data scope, with modifications to specific tests and methods.

Key points:

Optimized Displacement class tests by caching reference locations and limiting data scope.
Modified test_get_all_users_in_reference_location and test_subscriber_with_home_loc_but_no_calls_is_nan in flowmachine/tests/test_displacement.py.
Added store() method to cache daily_location results.
Introduced subscriber_subset to limit data scope in tests.

Generated with :heart: by ellipsis.dev

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.30%. Comparing base (b3a93b4) to head (0df9736).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #6652 +/- ## ======================================= Coverage 92.30% 92.30% ======================================= Files 268 268 Lines 10590 10590 Branches 856 856 ======================================= Hits 9775 9775 Misses 676 676 Partials 139 139 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 3 weeks ago

Passing run #22840 ↗︎

0

4

0

Details:

Use reduced subset where possible
Project: FlowAuth	Commit: `0df973660c`
Status: Passed	Duration: 00:51 💡
Started: Jun 13, 2024 8:55 AM	Ended: Jun 13, 2024 8:56 AM

Flowminder / FlowKit