search

Flowpack / media-ui

The development repository for the new Neos media management interface
GNU General Public License v3.0
20 stars 16 forks source link

BUG: tag selection for asset does not consider chosen collection #187

Closed batabana closed 1 year ago

batabana commented 1 year ago

Description

After assigning a collection to an asset, I still get all tags in the tag selection dropdown instead of just the ones associated to the collection. I can select tags from other collections, leading to technically invalid tag assignments.

Steps to Reproduce

  1. Create collections with corresponding tags
  2. Select an asset, select a collection for it
  3. Open the tag selection

Expected behavior

Should only offer tags related to the chosen collection(s)

Actual behavior

The asset belongs to collection "Radsport", so the tag dropdown should only offer tag "Downhill-Event", instead it offers all available tags.

grafik

Sebobo commented 1 year ago

I intentionally didn't implement this feature from the old browser as I think it's very confusing and inconsistent. F.e. what happens when moving an asset from one collection to another? The tags don't disappear.

For the future I planned to use it the same way for assets and collections. To tag the entities and not resolve anything from that connection from one to the other.

What is the actual use case for your customer?

batabana commented 1 year ago

Mhm okay i see. I was assuming the "old way" would still be the basic functionality in the new media module.

The use case for the customer: They have different sections that act rather autonomously. And a lot of picture "galleries" from different events in different sections. The idea was to use collections for the sections, tags for the events and nest them accordingly. The events usually have rather unspecific names though - so it will be hard for them to choose from the long list of tags if they are not filtered by section. And the rest of our implementation kind of depends on the tags being correctly set according to the collection they are in. Also it is very unlikely that a collection for an asset has to be changed, but I understand that this is specfic to their use case. Actually a more folder based option to upload and manage pictures would be even better for their usecase, that's why we tried to find an equally easy workflow with the collection- and tags-concept.

Sebobo commented 1 year ago

Then you will be happy to know that folder feature related to https://github.com/Flowpack/media-ui/issues/64 will hopefully released in the next weeks. The folder feature is fully working, but I'm in the testing and polishing phase and also need a PR in the Neos core merged. That should solve a lot of use cases like the one you describe.

Additional sponsorship and help with the feature is of course very welcome.

batabana commented 1 year ago

Sounds perfect :) Thanks for the explanations. I guess I'll close this issue then. Apparently I can't ^^'