search

Flowpack / media-ui

The development repository for the new Neos media management interface
GNU General Public License v3.0
20 stars 16 forks source link

TASK: change hover style of cancel button to error in CreateAssetCollectionDialog #200

Closed crydotsnake closed 10 months ago

crydotsnake commented 10 months ago

What I did

I change the hover style of the cancel button in the CreateAssetCollectionDialog to error. Because its standard in Neos for Discard/Cancel Buttons that they are red. At least, I have not seen anything else yet.

How I did it

Adjusted the CreateAssetCollectionDialog.tsx component.

How to verify it

after

crydotsnake commented 10 months ago

Unfortunately I saw only after creating the pull request (🤦🏽) that in the Delete Dialog the buttons are also not consistent. The button to delete the collection should be green, and the cancel button should be red there imo. But afaik there is no component for the delete button. Its all controlled via the ApprovalAttainmentStrategy.tsx

collection-delete-dialog

PRGfx commented 10 months ago

Imho this button style should only be used for "dangerous"/destructive actions. If "cancel" doesn't mean you lose notable progress in a form, I feel like it shouldn't be emphasized.

Sebobo commented 10 months ago

@crydotsnake all the cancel buttons I usually encounter are grey and blue when hovered. Why should it be red?