search

Flowpack / media-ui

The development repository for the new Neos media management interface
GNU General Public License v3.0
21 stars 16 forks source link

BUG: Metadata don't get applied on newly assigned images in image editor #239

Open dlubitz opened 2 months ago

dlubitz commented 2 months ago

Description

If you try to change meta data of an image, that has selected by image editor and has not been applied yet to the node, the meta data doesn't get applied to the image.

Steps to Reproduce

  1. Open a page and select a node with an image editor
  2. Click MediaLibrary Icon image
  3. Select any image
  4. Click on image in image editor again (without applying changes to the node) image
  5. Add or change title/description/copyright and click "Apply" within the media library image

Expected behavior

The meta data of the image should get applied.

Actual behavior

Nothing happens, No request is sent. After reopening the media library, the changes to the meta data are gone.

Affected Versions

Neos: 8.3.9 UI: 8.3.9 Media Module: 1.3.1

Sebobo commented 1 month ago

This is actually a Neos UI bug.

When there are unapplied changes in the inspector the action opens the secondary editor with a different z-index of 65 --zIndex-SecondaryInspectorElevated and therefore hides the dialog container with the confirmation dialog with z-index 55 --zIndex-Dialog.

This happens due to the inspector thinking the You still have changes. What do you want to do with them? dialog should be shown via shouldPromptToHandleUnappliedChanges.

So we need a separate linked issue in the Neos.UI and investigate. There is nothing I can do in the Media.UI IMO.