`FixedPoint::integer` is by value, `Generic::integer` is not

FluenTech / embedded-time

Time(ing) library (Instant/Duration/Clock/Timer/Period/Frequency) for bare-metal embedded systems

Apache License 2.0

87 stars 17 forks source link

`FixedPoint::integer` is by value, `Generic::integer` is not #107

Closed korken89 closed 2 years ago

korken89 commented 3 years ago

Hi @PTaylor-us

I think this was an oversight when the integer API was changed. Now the API has bifurcated, should I fix a PR and maybe we should release a new version?

PTaylor-us commented 3 years ago

Absolutely correct. I didn't think to change Generic::integer. I'll take a look at this a little later today. Thanks for the heads-up.

PTaylor-us commented 3 years ago

Fixed (589acd79d296e704d8a0576a45877db3607f3792)

korken89 commented 3 years ago

Hi, the fix seems to not have made it to master?

PTaylor-us commented 2 years ago

merged to master May 30