search

FluenTech / embedded-time

Time(ing) library (Instant/Duration/Clock/Timer/Period/Frequency) for bare-metal embedded systems
Apache License 2.0
90 stars 17 forks source link

Release/v0.13.0 #114

Open PTaylor-us opened 3 years ago

PTaylor-us commented 3 years ago

Features

Changes

korken89 commented 3 years ago

Great to see this getting released!

burrbull commented 3 years ago

On my machine read_timer test fails time to time.

running 4 tests
test periodic_expiration ... ok
test oneshot_wait ... ok
test read_timer ... FAILED
test periodic_wait ... ok

failures:

---- read_timer stdout ----
thread 'read_timer' panicked at 'assertion failed: `(left == right)`
  left: `Ok(Seconds(1))`,
 right: `Ok(Seconds(0))`', tests/timer.rs:105:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    read_timer

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
PTaylor-us commented 2 years ago

On my machine read_timer test fails time to time.

@burrbull That sounds like a timing issue if the tests are run multithreaded. Using the --test-threads=1 option may clear this up. (see https://github.com/FluenTech/embedded-time/blob/master/.github/workflows/ci.yml)

ZoeyR commented 2 years ago

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

burrbull commented 2 years ago

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

ZoeyR commented 2 years ago

Any news on when this might get released? I can't upgrade rtic to 1.0 without the changes in this branch.

RTIC 1.0 depends on fugit, not embedded-time

According to this: https://github.com/rtic-rs/cortex-m-rtic/issues/578 that is not the case

korken89 commented 2 years ago

Both work :)

ghost commented 2 years ago

It's been a year since this PR was opened and 8 months since the last comment, how's progress going on this release? Is there anywhere that needs additional assistance I or others may be able to provide to get this to the finish line?

Particularly I'm in need of the change for the Generic duration not implementing FixedPoint, which in my case blocks me from doing clock.new_timer(generic_duration).