search

FluentLayout / Cirrious.FluentLayout

FluentLayout for Xamarin.iOS - sample uses MvvmCross
Microsoft Public License
148 stars 54 forks source link

New advanced contraint extensions #16

Closed softlion closed 8 years ago

softlion commented 9 years ago

New AddConstraints overloads for ease of use Updated nuget to 3.5 stable

slodge commented 9 years ago

Thanks :)

I like what the new extension methods do to reduce the amount of calls in the advanced methods

I'm not sure about the optional parameters - not sure how "fluent" they feel - but I'm 50:50 on this... I like what they do to the code (and that's probably more important than any "fluent" feelings...)

I'm hoping @gshackles or others who are actively using this can make the decision :)

slodge commented 9 years ago

Looking at the existing file.... maybe I'm too late on the optional parameters - looks like there are plenty of them in there already :)

So... I'm guessing we should just pull this in :)

Will leave to @gshackles anyway :)

Also.... wonder if we should move this over in to some other gh organisation? Feels like others are contributing to it way better than me at the moment :)

gshackles commented 8 years ago

Closing this since the branch/PR has gotten stale and has conflicts, but please do open a new PR if there are still changes you'd like to contribute!

softlion commented 8 years ago

Well I won't contribute anymore as it was ok at the time I made the pr, and I don't like work twice. Merge it if you want an improved version of the lib. I have my own now.