Closed rogerwcpt closed 4 years ago
This PR does way more than described, it removes the fake script and uses a cake script to build, not even using the default bootstrappers cake provides.
Also I would
Thanks @Cheesebaron for your guidance. Please bear with me, its my first ever PR.
I do agree, the PR does way more than it should, I'll re-do it and break it up in to smaller chunks.
I've seen more Cake than Fake, should we stick to Fake?
Thanks for your comments, appreciate it, I'm happy if this PR is rejected and I start again.
I would probably stick to the FAKE script as is.
As for the two other things I pointed out, I would wait for @gshackles to pitch in as he is the maintainer here 😄
Sorry for the delayed response (my schedule is a total mess lately), and thanks for the contribution! Also, congrats on your first PR! 🎉
I agree with Tomasz here that there's a lot going on, so I think we should split this up into some distinct pieces/PRs. It seems like doing the MvvmCross updates first might be a good place to start, and set the stage for the tvOS changes and sample you worked on.
In terms of the build system, given that we're already set up with FAKE, including our CI builds, I don't see a real compelling reason to swap that out at this point.
Thanks again for putting in the time to work on this! I look forward to getting this cleaned up and merged soon 😄
Thanks @gshackles , no problem. Agreed, i'll make the changes incrementally, starting with MVVMCross updates and stick to FAKE.
Closing this out since it's gotten stale, and also see some new convo in #54 that might cover some of this!
Extended the project to support tvOS