FluffyMaguro / SC2_Coop_Overlay

Overlay for StarCraft II Co-op showing post-game statistics
https://www.maguro.one
GNU General Public License v3.0
71 stars 15 forks source link

More Reorganising data for `SC2Dictionaries` #13

Closed aneroid closed 3 years ago

aneroid commented 3 years ago

Along the same lines as 3f6535ce and FluffyMaguro/SC2_Coop_overlay#3, I've moved some of the data into SC2Dictionaries\__init__.py and the rest into txt/csv files.

  1. moved to SCOFuncs.SC2Dicts.init:
    • duplicating_units
    • revival_types
    • icon_units
    • self_killing_units
    • commander_no_units
    • units_killed_in_morph
    • primal_combat_predecessors
    • UnitAddLossesTo
  2. moved to txt/csv files:
    • skip_strings --> skip_strings.txt
    • dont_show_created_lost --> dont_show_created_lost.txt
    • aoe_units --> aoe_units.txt
    • tychus_outlaws --> tychus_outlaws.txt
    • commander_upgrades --> commander_upgrades.csv
    • dont_include_units --> dont_include_units.txt
    • salvage_units --> salvage_units.txt
    • and...
    • Mutators --> Mutators.csv
    • mutator_ids --> mutator_ids.csv

Additionally, if you need it, I could write something to handle amon_player_ids (dict {str: set[int]}) and bonus_objectives (dict {str: int}).

I highly recommend a separate handler for map_names, it's a pretty big di... item. Perhaps something like Native Mapname --> ID only and a separate one for ID --> Eng name. But that would involve also changing the code that uses it. (At the very least, it could just be a separate csv with its own special loader.)

FluffyMaguro commented 3 years ago

I appreciate the effort, but I would prefer to keep it this way. Thank you.