search

Flugtiger / birt

Eclipse BIRT™ The open source reporting and data visualization project.
http://www.eclipse.org/birt
Eclipse Public License 1.0
5 stars 4 forks source link

Updated the Spudsoft Excel emitter to the latest code from the author's repository #46

Open hvbtup opened 5 years ago

hvbtup commented 5 years ago

Please see my commits from Oct 25 to Oct 28, 2019. After the Spudsoft Excel emitter was included into BIRT (May 17, 2013) for 4.3.0, many new features and bug fixes have been added by its author Jim Talbut, but these changes never made it into newer BIRT versions. I'm a GIT noob, I don't know if and how it is possible to choose a specifiy set of commits for a pull request. My ultimate goal would be to see these changes added to the official BIRT repository.

Flugtiger commented 5 years ago

Hi, thank you for taking your time to make this pull request. I will review it shortly but answer your questions first:

I don't know if and how it is possible to choose a specifiy set of commits for a pull request

well, first you need to create a new branch on the current head of the main branch of the base repository (in this case "flugtiger/birt:flugtiger_master"). Then, you put all commits that you want to include in your pull request into this branch and eventually, you create a pull request with your own branch as source and the base branch in the base repository as target. More information can be found here: Creating a pull request

My ultimate goal would be to see these changes added to the official BIRT repository.

To do this, you have to open a separate pull request targeting the official birt repo. To make your changes be based upon the official repo, you can rebase your changes from the branch "flugtiger_master" onto (git rebase --onto) the main branch of the official repo ("eclipse/birt:master"). Please use a new branch for this rebase (otherwise you would affect this pull request). After this rebase you can open a pull request on the official repo with your rebased branch as source of the pull request. Please be aware, that the reactions of the maintainers of the official birt repository are very slow if there are any at all so it's hard to get anything into the official repo.

Flugtiger commented 5 years ago

In case you need more information on how to "put all commits that you want to include in your pull request into this branch", there are multiple options with git:

You could create a new branch on your current HEAD (with git branch <branch_name>) and then kick out all unwanted commits with an interactive git rebase OR you create a fresh branch at the HEAD of the flugtiger_master branch and then add all commits you want inside this branch with git cherry-pick.