Fluid-Dynamics-Group / distribute

easy to use distribtued computing
https://fluid-dynamics-group.github.io/distribute-docs
GNU General Public License v3.0
1 stars 0 forks source link

Joss Review: Install Warning #44

Open jeremylt opened 11 months ago

jeremylt commented 11 months ago

Cargo generated the following warning on installation:

   Compiling distribute v0.14.5 (/home/jeremy/.cargo/git/checkouts/distribute-b0a0fe8afb33e59f/ace15ae)
warning: variable does not need to be mutable
   --> src/server/schedule.rs:281:30
    |
281 |         if let Some((_ident, mut job_set)) = self
    |                              ----^^^^^^^
    |                              |
    |                              help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

warning: `distribute` (lib) generated 1 warning (run `cargo fix --lib -p distribute` to apply 1 suggestion)

I think that is a false warning. If so, you can #[allow(unused_mut)] to the offending function.

jeremylt commented 11 months ago

Running cargo test has these two additional warnings:

warning: unused import: `distribute::cli::Run`
 --> tests/many_jobsets_single_sif.rs:1:5
  |
1 | use distribute::cli::Run;
  |     ^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `distribute::cli::Slurm`
 --> tests/many_jobsets_single_sif.rs:2:5
  |
2 | use distribute::cli::Slurm;
  |     ^^^^^^^^^^^^^^^^^^^^^^

warning: `distribute` (lib test) generated 1 warning (1 duplicate)
warning: `distribute` (test "many_jobsets_single_sif") generated 2 warnings (run `cargo fix --test "many_jobsets_single_sif"` to apply 2 suggestions)