search

FluidCoding / improved-asp-html

Improved ASP Classic Grammar and Snippets for Atom
http://www.Fluidcoding.com
MIT License
4 stars 0 forks source link

problem in marking #3

Open taludelito opened 6 years ago

taludelito commented 6 years ago

Congratulations on the work, the situation below presents a problem

<% 'test %><script type="text/javascript">blabla; <% 'bad situation %> </script>

taludelito commented 6 years ago

I found an impromptu solution to this problem. Which was also reported here (https://github.com/ansballard/language-asp/issues/1) the solution is here: (https://github.com/atom/language-php/blob/master/grammars/html.cson) as in php this problem does not occur, I thought the solution would be there, and it really is. I'm not very good at programming, but I did the following that can be improved by those who have a greater knowledge:

I have picked up this html.cson file quoted above, and replace it with html-asp.cson (https://github.com/FluidCoding/improved-asp-html/blob/master/grammars/html-asp.cson) I kept 'scopeName': and 'fileTypes' from html-asp.cson and copied all the rest of html.cson (php) and only substituting \? per % and php by asp

so it looked like this: https://github.com/taludelito/language-asp/blob/master/grammars/html-asp.json

I believe that it is not the best solution, and that changes of specific php points should be changed to specific points of the asp, however this solves the problem.

ps .: sorry for my bad English, automatic translation from google