search

FluidSynth / fluidsynth

Software synthesizer based on the SoundFont 2 specifications
https://www.fluidsynth.org
GNU Lesser General Public License v2.1
1.76k stars 246 forks source link

Fix libinstpatch and sndfile not being discovered on Windows #1299

Closed derselbst closed 6 months ago

derselbst commented 6 months ago

libinstpatch and sndfile are using different library filenames on Windows. Previously, the CMake scripts were only looking for their Unix names resulting in the libraries not being found. This PR fixes it, and therefore implicitly restores DLS support for the precompiled Windows binaries.

In addition, we're no longer relying on sndfile's pkgconfig file to report correct private libs to figure out whether it has OGG / Vorbis support. This change restores SF3 support for precompiled Windows binaries.

This latter change revealed two more problems: 1) parsing of the OPUS_VERSION was broken and could led to an index-out-of-range error, and 2) the logic in Findmpg123 was missing the IMPORTED keyword.

Fixes #1298

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud