search

FluidTYPO3 / fluidcontent

TYPO3 extension Fluidcontent: Fluid Content Element Engine
71 stars 64 forks source link

Content Element Wizard Tab Name cannot handle spaces #391

Closed mkrappitz closed 7 years ago

mkrappitz commented 7 years ago

If I setup my new content element wizard tab name as follows all is good, the wizard tab is named "MyElements":

... Once I use as space in the group name, the wizard tab is named "group_My_Elements" and not "My Elements": ... TYPO3 7.6.15 flux 8.0.2 fluidcontent 5.0.0
mithri commented 7 years ago

I can confirm. The same here with flux 8.1 and fluidcontent 5.1

steffenk commented 7 years ago

first you have to create a translation. If your Tab is named MyElements, you need to add following key to your locallang.xlf: fluidcontent.newContentWizard.group.MyElements

second my pull request #391 has to be accepted and merge to get the change visible.

mkrappitz commented 7 years ago

But why not leave it as it is with the name settable directly in the options? This ia another kind of breaking change that is not mentioned anywhere.

dacostafilipe commented 7 years ago

Had the same issue and came to the same conclusion as @steffenk

The main issue here seems to be in buildAllWizardTabGroups and buildWizardTabItem. If more people are interested I could try to make a PR.

For me, @steffenk 's PR #396 would be more then enough if merged.

mkrappitz commented 7 years ago

Still it would make sense to me to let people just enter whatever they want in the setting withing the viewhelper and just display it as it is. Besides that one could allow to enter a path to a locallang marker and display that instead. This would be very straightforward to my mind and would not need to break existing installations like it is the case now.

dacostafilipe commented 7 years ago

I've created a PR for this issue here, have a look : #403

mkrappitz commented 7 years ago

Looks good. Thanks. Did an review with approval.