search

FluidTYPO3 / fluidcontent

TYPO3 extension Fluidcontent: Fluid Content Element Engine
71 stars 64 forks source link

[BUGFIX] Added support for spaces in group name #403

Closed dacostafilipe closed 7 years ago

dacostafilipe commented 7 years ago

If the selected tab does not exists yet, create a new tab with the given tab title instead of the tabid. (similar to #396 but required here)

Use group name instead of tabid if we don't find a translation in our locallang file.

Removed the usage of underscores when create tabs.

PS: I tried to follow your "guidelines for contributing" but I could not. Maybe that page needs an update?

dacostafilipe commented 7 years ago

This is related to #391

NamelessCoder commented 7 years ago

Removed the usage of underscores when create tabs.

About half of the change is about removing the underscores - could you explain why that is necessary?

PS: I tried to follow your "guidelines for contributing" but I could not. Maybe that page needs an update?

It should still be valid information with the exception of running the vendor/bin/make command - now, you can simply do composer install and run vendor/bin/phpunit. The workflow isn't that important anymore since we can now do squashing and edits directly on github.

dacostafilipe commented 7 years ago

About half of the change is about removing the underscores - could you explain why that is necessary?

Because having underscores in the generated TSconfig seems to break rendering (Elements would appear in an other random tab, or not at all) and removing them solves it.

I tried to investigate why, but stopped after finding the solution above as those underscores do not seem like a vital feature in the first place.

dacostafilipe commented 7 years ago

Okay, I found the problem.

Going by core's "NewContentElementController->removeInvalidElements" line 515+516 and line 525, underscores in group names are not supported.

Now, should we change the way core handles this, or should we remove the underscores from fluidcontent? How about doing both?

NamelessCoder commented 7 years ago

I think the core does something with underscores by design, but feel free to open an issue in the TYPO3 core bug tracker. Fluidcontent will be deprecated at some point soon, in favor of CTypes via Flux - in which this problem doesn't exist.

dacostafilipe commented 7 years ago

Just as information.

The underscore removal does net seem to be needed anymore on 8.7 LTS. I don't have time to investigate why for the moment, but will give it a try in the near future.

mkrappitz commented 7 years ago

How did you get flux / fluidcontent running on 8.7 anyway? I see no 8.7 capable version on github.

dacostafilipe commented 7 years ago

I moved to composer just after this PR here and it seems to let me install flux 8.1.0 / fluidcontent 5.1.0 without issues.

flux requires typo3/cms ^7.6|^8.4 fluidcontent requires typo3/cms >=7.6.13, <7.6.99|^8.4.1

Keep in mind that with composer, all those dependencies in ext_emconf are not enforced anymore.