search

FluidTYPO3 / fluidtypo3-gizzle

Gizzle package to accept post-receives on FluidTYPO3 repositories
3 stars 5 forks source link

What to do when repo name does not match extension key? #5

Closed fnagel closed 9 years ago

fnagel commented 9 years ago

Running into this issue:

Directory \u0022my-extension\u0022 has a name indicating it is not a TYPO3 extension. Expected folder name should contain only a-z, 0-9 and underscores. (1412208381)

I've seen there is a option in typo3-repository-gizzle to pass the extension key as URL path but this seems not possible when using fluidtypo3-gizzle, right?

Any other way to change extension key per repository?

NamelessCoder commented 9 years ago

Totally in a commit/release frenzy here ^^

https://github.com/NamelessCoder/gizzle-typo3-plugins/commit/ac09f2fe74667a23b171178dd277b5e1abe716d0

NamelessCoder commented 9 years ago

Implementation sort of similar to https://github.com/NamelessCoder/typo3-repository-gizzle/blob/master/src/GizzlePlugins/ExtensionRepositoryReleasePlugin.php#L47 but builds on an option rather than some third-party user input.

fnagel commented 9 years ago

Thanks a lot! Seems to work as expected -- at least the folder is created correctly now.

TER deploy itself fails at the moment as I'm running into an odd issue, see https://github.com/NamelessCoder/typo3-repository-client/issues/1

I like the idea of setting the extension key in the URL -- that way its not needed to add an specific setting yml for each extension just because the repo name. What about a combination of both options?

NamelessCoder commented 9 years ago

Kapow! https://github.com/NamelessCoder/gizzle-typo3-plugins/commit/775947304c479699238cdf14e08c5474c14b6199

fnagel commented 9 years ago

Works like expected -- expect that my TER upload fails due to that dependency issues.

Thanks again! Do you have a amazon wishlist? It seems you need some more fine metal music :-D

NamelessCoder commented 9 years ago

I wouldn't like receiving SOAP requests with dependency info either, poor TER ^^

I sure do have a wish list, there's a little bit of everything on there: http://www.amazon.co.uk/registry/wishlist/4DBU03X4O79U - thanks! ;)

fnagel commented 9 years ago

Did you receive a package? Amazon claims it "will be delivered soon" for more than a month now...

NamelessCoder commented 9 years ago

I sure did - thanks for the metal! Received almost a month ago and enjoyed several times since then ;)