FluidTYPO3 / flux

TYPO3 extension Flux: Dynamic Fluid FlexForms
https://fluidtypo3.org
145 stars 214 forks source link

field.inline.fal causing errors in 7.6 #1013

Closed vickygr89 closed 8 years ago

vickygr89 commented 9 years ago

When adding an image we got a 500 error on save. And then in the Error Log we see the following:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1446996319: Configuration retrieved from FlexForm is incomplete or not of type "inline". | UnexpectedValueException thrown in file /home/typo3_src/7.6latest/typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php in line 811. Requested URL: http://www.-------.stwdev.com/typo3/index.php?ajaxID=%2Fajax%2Frecord%2Finline%2Fcreate&ajaxToken=b1af04b81ba878c7cc40ba1dd13e8727b3ec8bbc

We pulled the latest flux from GIT and got same results.

julianxhokaxhiu commented 8 years ago

Even with the latest development branch status, downloaded like 1 minute ago, it still doesn't work.

But after I applied this patch, magically it works again. So, for everyone having FAL 500 issue just merge this patch: https://github.com/monosize/fluidcontent/commit/3556fe61f996fc0eec7e02e91b9c3a50071073b3

Tested and working on Typo3 7.6.x ( including the last 7.6.3 ) with latest Flux and all related extension downloaded from development branch.

NamelessCoder commented 8 years ago

The fix is not merged yet.

kimchristiansen commented 8 years ago

Are there any plans when the fix will be merged?

glucka commented 8 years ago

Just a note: The patchs do not work if you have compatibility6 extension installed.

DenisMir commented 8 years ago

What is the current status of this issue? Which patches are needed at the moment and is the TYPO3 team at least aware of the bug?

NamelessCoder commented 8 years ago

The TYPO3 team is fully aware of the bug. The workaround I created was made after discussing the issue in depth with Christian Kuhn. The summary of that conversation is: there are two parts of this issue; one is that the use case fails in general (hook needs record, doesn't get record) the other is that any "easy" workaround will not cover new records (see commit about patch for FormEngine above). The first issue may at some point be solved with a bug fix release for TYPO3 (since it is technically a regression) but the second part is not expected to be solved until TYPO3v8.

The solution itself involves rewriting large parts of the TYPO3 core's JS surrounding IRRE handling and strategy for storing AJAX invocation parameters in esoteric string formats in the DOM. A plan is underway - if you wish to help please contact Christian Kuhn as I am not (yet) personally involved in that particular adventure.

And with this comment I now lock the issue: every last piece of relevant information is now contained in this thread, the issue itself is worked around in development branch and the workaround will be included in the next TER release. The TYPO3 core aspects are also documented and further discussion is deferred to the TYPO3 core bug tracker (which at the time of writing this, to my knowledge does not have a Forge issue describing the required/planned JS rewiring task explained above).

Again, thanks everyone for your patience in this matter. Some issues seem deceptively simple to solve but have very deep roots - and this one is definitely one of those.