FluidTYPO3 / flux

TYPO3 extension Flux: Dynamic Fluid FlexForms
https://fluidtypo3.org
146 stars 212 forks source link

PHP 8 Warning in Classes/Provider/PageProvider.php line 402 #2092

Closed ako-3004 closed 1 year ago

ako-3004 commented 1 year ago

another undefinded array index warning by php8 in Classes/Provider/PageProvider.php line 402

TYPO3\CMS\Core\Error\Exception PHP Warning: Undefined array key "settings.something" in [...]/flux/Classes/Provider/PageProvider.php line 402

only got this when adding a new field to a existing page flux form configuration. Not quite sure what happens here, but for me this fixes the warning:

changed $empty = (true === empty($values[$name]) && $values[$name] !== '0' && $values[$name] !== 0);

to

        if (empty($values)) {
            $empty = true;
        } else if (!isset($values[$name])) {
            $empty = true;
        } else {
            $empty = (true === empty($values[$name]) && $values[$name] !== '0' && $values[$name] !== 0);
        }