search

FluidTYPO3 / flux

TYPO3 extension Flux: Dynamic Fluid FlexForms
https://fluidtypo3.org
148 stars 214 forks source link

Flux contents ignored by l10nmgr extension in TYPO3 v12 #2163

Closed TopSolid closed 6 days ago

TopSolid commented 1 week ago

I have checked that the bug exists in the dev-development branch Yes If you're about to answer "no" here, it is your responsibility to check dev-development before opening a bug report!

I have checked that there are no already open issues or recently closed issues about this bug Yes

If you're about to answer "no" here, it is your responsibility to first check the open and recently closed issues for potential duplicaates.

Describe the bug I use l10nmgr in v12 and it ignores all flux contents when exporting in XML. Despite latest versions have been used:

TYPO3 12.4.15 fluidtypo3/flux dev-development 907b7ab l10nmgr EA 12 version from 21/06 release

With v11, a patch was possible https://github.com/FluidTYPO3/flux/issues/1805 where a function "patchTceformsWrapper()" was missing. Since v12, it seems that it is not necessary anymore: https://github.com/FluidTYPO3/flux/blob/development/Classes/Builder/FlexFormBuilder.php#L123

Does it come from flux or l10nmgr? not easy to find... Can anyone here help?

TopSolid commented 1 week ago

Hello guys Any help on that topic? Is patchTceformsWrapper() not working in v12?

NamelessCoder commented 6 days ago

As far as I am aware this method is not necessary at all on TYPO3v12 and is only partially necessary on TYPO3v11 and below, which triggers some edge case errors with things like the suggest XHR receiver without the TCEforms wrapper.

It should not be necessary at all with the most recent version of EXT:l10nmgr which has its own patchTceFormsWrapper method (apparently a 1:1 copy of the method from Flux, added in v11.0 of EXT:l10nmgr): https://github.com/CodersCare/l10nmgr/blob/3ee71720066bafdf2c5abd736c1f97c6f3ae61ec/Classes/Model/Tools/Tools.php#L551.

In short: even if Flux doesn't apply this wrapper on TYPO3v12, l10nmgr will apply it, as long as you use v11.0 or higher of l10nmgr. I would certainly expect this patch to also be in l10nmgr EA.

If that doesn't solve your problem there might be another cause for it, but I can't help you track it down since I don't have EA access for l10nmgr. You'd have to bring this problem to the l10nmgr team.