search

FluidTYPO3 / vhs

TYPO3 extension VHS: Fluid ViewHelpers
https://fluidtypo3.org
Other
189 stars 228 forks source link

[BUGFIX] Remove deprecated call to GeneralUtility::unQuoteFilenames #1662

Closed mh0rst closed 3 years ago

mh0rst commented 4 years ago

The deprecated method GeneralUtility::unQuoteFilenames has been removed from TYPO3 v10, which breaks the LinkViewHelper

This PR introduces a copy of aforementioned method. The LinkViewHelper is the only instance using unQuoteFilenames, so I guess the copy should go there, too.

NamelessCoder commented 4 years ago

@mh0rst Thanks for the patch - but I think we should instead remove the entire processing block that is entered if $pageUid is not numeric. The pageUid argument is specified as integer and should not support the typolink syntax with space-separated parts. The parts that are possible to specify this way can also be specified as either direct tag attributes or through additionalAttributes.

If you rewrite the patch to drop the added method and remove this condition block then I will happily merge it ;)

mh0rst commented 3 years ago

@NamelessCoder you are right, I amended the change set, passing a string to $pageUid now triggers a log warning and returns. EDIT: Build breakage is caused by unavailable packagist server