FluidTYPO3 / vhs

TYPO3 extension VHS: Fluid ViewHelpers
https://fluidtypo3.org
Other
189 stars 228 forks source link

deprecated code in ViewHelpers/Resource/AbstractImageViewHelper.php #1664

Closed almfisch closed 1 year ago

almfisch commented 4 years ago

Hi,

this 2 lines forced a deprecated error: 205: $template->init(); 206: constant('PATH_site');

Because of: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.4/Deprecation-85408-TemplateServiceInitDeprecated.html https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.4/Deprecation-85285-DeprecatedSystemConstants.html

I replaced the 2 lines with: $template; $template->getFileName_backPath = \TYPO3\CMS\Core\Core\Environment::getPublicPath() . '/';

Regards from Bavaria Andi

nostadt commented 4 years ago

I experienced same with

public/typo3conf/ext/vhs/Classes/Service/AssetService.php:643

Seems like this ext. is not compatible with T3 v10 even though it claims to be. Correct me if my impression is wrong.

$ ddev composer info typo3/cms-core | grep version
$ versions : * v10.4.5
$ ddev composer info fluidtypo3/vhs | grep version
$ versions : * 6.0.3
$ typo3-ter/vhs self.version
nostadt commented 4 years ago

@NamelessCoder informed me that there's a pending release within development

@AMartinNo1 fix is pending but release has not yet been made, see https://github.com/FluidTYPO3/vhs/commits/development - until release is made you can req fluidtypo3/vhs:dev-development as 6.0.4

In order to use an alias this repository needs to be registered manually in your composer.json

{
  "repositories": [
    {
      "type": "composer",
      "url": "https://composer.typo3.org"
    },
    {
      "type": "vcs",
      "url": "https://github.com/FluidTYPO3/vhs"
    }
  ],
}

Here's a link to the official documentation of composer alias.

NamelessCoder commented 1 year ago

Has been solved for quite some time - forgot to close the issue back then.