search

FluidTYPO3 / vhs

TYPO3 extension VHS: Fluid ViewHelpers
https://fluidtypo3.org
Other
189 stars 228 forks source link

GLOBALS['TYPO3_CONF_VARS']['GFX']['colorspace'] changed since Typo3 v8 #1748

Closed ndq1 closed 2 years ago

ndq1 commented 2 years ago

Hi,

I am currently working on PDF thumbnail generation using v:media.pdfThumbnail and noticed that the rendered thumbnails seems to be darker than the pdf page.

I did some research and as it seems imagemagick changed from RGB to sRGB which will lead to darker colors in the thumbnails.

So I changed the colorspace by setting $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace'] as described in the Typo3 v10 documentation (https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/GlobalValues/Typo3ConfVars/GFX.html?highlight=colorspace#globals-typo3-conf-vars-gfx-processor-colorspace). But the change didn't took effect.

After a little digging I noticed that in the VHS extension (https://github.com/FluidTYPO3/vhs/blob/04d7ac203d7726738b280ee2f2eec2ae24c73b48/Classes/ViewHelpers/Media/PdfThumbnailViewHelper.php#L85) the colorspace settings is being checked against GLOBALS['TYPO3_CONF_VARS']['GFX']['colorspace'] which had been changed to $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace']. (see https://forge.typo3.org/issues/92707)

Am I wrong or maybe am I missing something?

Thanks for your help.