search

FluidTYPO3 / vhs

TYPO3 extension VHS: Fluid ViewHelpers
https://fluidtypo3.org
Other
190 stars 229 forks source link

AssetInclusion Middleware does not return assets on a cached page #1768

Closed mkarulin closed 2 years ago

mkarulin commented 2 years ago

After updating to 6.1.1 and enabling caching, the javascripts that were included using the viewhelper stopped working. (Example: <v:asset.script name="handlebars" overwrite="true" movable="true" path="{settings.javascript.handlebars}" />)

The script tag appears only when cache is cleared, and disappears after reloading the page from cache.

I tracked it down to the change implemented in https://github.com/FluidTYPO3/vhs/commit/863e0304b4e0b4a91ed5272c4d152b5dde56799b

TYPO3 versions tested: 9.5, 10.4, 11.5 Problem started with in 6.1.0

Originally posted by @mkarulin in https://github.com/FluidTYPO3/vhs/issues/1736#issuecomment-1118452118

Keinbockwurst commented 2 years ago

I can confirm this. After Downgrading to 6.0.5 its working again.

xperseguers commented 2 years ago

Confirming this as well.

cweiske commented 2 years ago

I had the same problem with v:asset.style on vhs 6.1.1. The <!-- VhsAssetsDependenciesLoaded ... --> comment would only be there if the page was non-cached. The patch fixes this problem.

mkarulin commented 2 years ago

When will this be released? Regards.