FluidityProject / fluidity

Fluidity
http://fluidity-project.org
Other
366 stars 115 forks source link

Surface integral part of the viscous term #191

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi,

This is a question and not an issue.

theory https://github.com/FluidityProject/fluidity/blob/b3d0955678f6bc7af537d44b54cd7e89f641d3a3/assemble/Momentum_CG.F90#L1034

I see that the surface integral part of the advective term is added whenever the boundary condition allows normal flow. However, I don't see a section in the subroutine that takes care of the surface integral part of the viscous term.

PS: Is the fluidity mailing list still active?

stephankramer commented 6 years ago

The viscous surface integral is indeed missing. So when considering the momentum equation on its own it would indeed be applying the wrong boundary condition. I believe the argument, why this is allowed, is that this gets corrected in the pressure correction. I think you can find more details in the Gresho and Sani "Incompressible Flows and the Finite Element Method" books, there are various subtly different pressure correction methods, where the details are all in the treatment of boundary conditions. The reason the viscous integral is often left out, is that it's actually a little tricky to implement as it involves the integral of a normal gradient over a surface, where this gradient depends on degrees of freedom that are not on the surface, so you can't just restrict it to a lower dimensional integral.

The fluidity mailing list is still active, yes - response time may vary though, depending on the type of question.

ghost commented 6 years ago

thanks.