search

FluidityProject / fluidity

Fluidity
http://fluidity-project.org
Other
365 stars 115 forks source link

Add PETSC_DIR mention to config help #306

Closed adigitoleo closed 3 years ago

adigitoleo commented 3 years ago

This adds mention of the PETSC_DIR environment variable to the CLI help of the configure script. I thought it would be nice to add since PETSc is a fairly critical dependency of fluidity.

While I was at it I sorted the env vars alphabetically.

gnikit commented 3 years ago

So the configure script is autogenerated using GNU autotools, that is why some entries in the configure are out of order. If you wish to make any permanent changes to the configure script you need to edit the configure.in. Now whether or not this is a useful change for master I will leave it for the maintainers of the repo.

FYI the configure.in and *.m4 files work just fine for most cases but there are some issues that I have encountered i.e. compiling with Intel or linking to different PETSc libs. That possibly indicates the need update the configure scripts, but that is more challenging than it sounds since (usually) you have to maintain backwards compatibility.

adigitoleo commented 3 years ago

I see, thanks for the info. This PR was clearly premature and I'll close it at least until I have understood more about autoconf etc. I don't trust myself to do an overhaul of the configure scripts just yet, and I can understand that it would be a delicate task.