Closed stephankramer closed 3 years ago
This all looks good!
My only question would be whether we should add the beaker_blob[_adapt]
tests with the owner currently set as bsnelling
, this appears to be a layover from the 2016 PR #130 .
Also, the beaker_blob
test is surprisingly slow. Thought it was just 1D but turns out it's extruded and ends up being quite high resolution. Is that necessary or could the vertical resolution (at least) be lowered a little? The _adapt
version starts out with the same mesh but is much better post adapt.
Thanks, @cianwilson - much appreciated. I've changed ownership of these tests. On my laptop beaker_blob runs in just 46s. I'd be interested to know if it's much slower for you cause that could indicate solver issues...
Not horrendously slow admittedly. 1:30 for me on beaker_blob
. But when I look at it, it's quite high resolution. It fails some tests at lower resolutions but as far as I can tell it appears to be a regression test (and sometimes testing things that aren't even guaranteed to be true, like conservation of the volume fraction) so I was wondering if the resolution could be dropped and the regression numbers adjusted. I just didn't know if it was worth devoting a few minutes of testing time to tests that are just doing regression. At double the mesh spacing it drops to 20 seconds for me.
This PR includes the following:
Other fixes related to free surface mesh movement in this PR (originally in #130):
OriginalCoordinates
before the adapt so that the domain with the (assumed flat) initial free surface is adapted. After the adapt, the mesh is moved back according to the interpolated free surface fieldFixes to particles with a moving free surface: