FluidityProject / fluidity

Fluidity
http://fluidity-project.org
Other
362 stars 113 forks source link

Update versions of actions to avoid deprecation warnings #367

Closed Patol75 closed 1 year ago

Patol75 commented 1 year ago

GitHub has made some changes to Actions (links below), and as a result, versions of actions used in our workflows should be updated.

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Patol75 commented 1 year ago

CI is all green, please feel free to approve and merge.

gnikit commented 1 year ago

@stephankramer any idea what's happening with the Bionic checks? As far as I can see, Unit Bionic and Medium Bionic seem to be missing from ubuntu.yml: testing > strategy > matrix > name and include

stephankramer commented 1 year ago

Yes, that's weird. I've removed these from main - and if you look at https://github.com/FluidityProject/fluidity/actions/runs/3581331774 it's seems all happy and green (without these two as intended) - it's only on this PR that it seems to insist on these still being run? I'll just override and merge it regardless - hopefully we won't see this come back on other PRs

gnikit commented 1 year ago

@stephankramer I think you might want to have a look under Settings > Branches branch protection rules. Something there seems to be out of sync (I can't see it myself only Organisation Owners can)

stephankramer commented 1 year ago

Yes, thanks, you were right: it specifies explicitly which statuses are required for a merge to be allowed. Removed the Bionic medium/unit ones now and added the Jammy ones