search

FluidityProject / fluidity

Fluidity
http://fluidity-project.org
Other
362 stars 113 forks source link

OpenMP build broken #375

Closed stevendargaville closed 9 months ago

stevendargaville commented 1 year ago

The commit 5963c4c050cda809c3c0c2720af499a5db4081dc broke the OpenMP build by removing some variables from Colouring.F90. The fix is just reverting the changes to Colouring.F90 in that commit (which was just about removing unused variables)

stevendargaville commented 1 year ago

The same is true in Advection_Diffusion_CG.F90 and Advection_Diffusion_FV.F90, where the cache_valid logical was removed.

stephankramer commented 1 year ago

I don't think it's a matter of just reverting I'm afraid: it would fail the linting test. Also these changes have caused some grief already in terms of merge conflicts, and reverting would just add on to that.

The fix should be relatively easy: variables that are only used in #ifdef blocks should be declared inside a equivalent #ifdef. The underlying issue however is that this openmp functionality is not tested at all, not even a build test, and so as long as that's the case it can be broken by any arbitrary commit.