Fluorohydride / ygopro-core

ygopro script engine.
MIT License
327 stars 134 forks source link

update `EFFECT_UNRELEASABLE_NONSUM` #515

Closed Lyris12 closed 10 months ago

Lyris12 commented 11 months ago

for Ritual Beast Ulti-Reirautari (聖霊獣騎 レイラウタリ):

salix5 commented 11 months ago

How about adding new parameter to Duel.CheckReleaseGroup, Duel.CheckReleaseGroupEx?

For example:


---@return boolean
---@param reason integer
---@param player integer
---@param f function|nil
---@param count integer
---@param ex Card|Group|nil
---@param ... any
function Duel.CheckReleaseGroup(reason,player,f,count,ex,...) end
Lyris12 commented 11 months ago

How about adding new parameter to Duel.CheckReleaseGroup, Duel.CheckReleaseGroupEx?

For example:

---@return boolean
---@param reason integer
---@param player integer
---@param f function|nil
---@param count integer
---@param ex Card|Group|nil
---@param ... any
function Duel.CheckReleaseGroup(reason,player,f,count,ex,...) end

That does not cover cards using only Duel.GetReleaseGroup for their costs. Take a look at the scripts for "The Hex Sealed Fusion" cards, for example, and at https://github.com/Fluorohydride/ygopro-pre-script/pull/1237 .

salix5 commented 11 months ago

Thank you!

To-do-list:

Is there anything else?

salix5 commented 11 months ago

516

I think we can change these functions.

Lyris12 commented 11 months ago

Not sure what the must_param is for, but that works for me, too!

Lyris12 commented 11 months ago

...PROVIDED the scripts are updated accordingly, 1st.

salix5 commented 11 months ago

Not sure what the must_param is for, but that works for me, too!

The number of necessary parameters.

Lyris12 commented 11 months ago

Not sure what the must_param is for, but that works for me, too!

The number of necessary parameters.

Ah, gotcha! Thanks!

salix5 commented 10 months ago

Since it is fixed in #516, this PR will be closed. Thank you for your help.