Fluorohydride / ygopro-core

ygopro script engine.
MIT License
321 stars 135 forks source link

add cost to EFFECT_TRAP_ACT_IN_HAND #575

Closed purerosefallen closed 4 months ago

purerosefallen commented 5 months ago

Added cost to effects like EFFECT_TRAP_ACT_IN_HAND, to deal with traps acting in hand like Red Reboot or Ebon High Magician.

Same things also did to EFFECT_QP_ACT_IN_NTPHAND EFFECT_TRAP_ACT_IN_SET_TURN EFFECT_QP_ACT_IN_SET_TURN

In addition, when multiple effects available to act in set turn or hand, the player would be asked to choose one to apply.

function c85551711.handcost(e,tp,eg,ep,ev,re,r,rp,chk,te)

end
salix5 commented 4 months ago

@mercury233

DailyShana commented 4 months ago

254 almost solve this issue

I think effect_set effect::required_handorset_effects is unnecessary, see #254

purerosefallen commented 4 months ago

@DailyShana required_handorset_effects is something to make code clean, to avoid checking effects in two places.

in addition, I prefer to make the cost as a standard cost format e,tp,eg,ep,ev,re,r,rp,chk. And, I perfer to make a new one rather than resolving conflicts in #254