search

Fluorohydride / ygopro

A script engine for "yu-gi-oh!" and sample gui
GNU General Public License v2.0
1.82k stars 588 forks source link

Redefine `STATUS_SUMMON_TURN` and so on, remove `Auxiliary.sumreg` #2467

Open mercury233 opened 1 year ago

mercury233 commented 1 year ago

Auxiliary.sumreg is added in https://github.com/Fluorohydride/ygopro/commit/04e7eb6603a246c2d1541a1e6992b9c2065dea0b , for handling this ruling. But shouldn't we handle it in ocgcore and let scripts use STATUS_SUMMON_TURN directly? @salix5

salix5 commented 1 year ago

Yes. It is a workaround.

edo9300 commented 1 year ago

Wouldn't this also be needed to handle the fact that if you copy one of such effects the monster that gained them shouldn't be able to use such effects? (If the scripts were to use the flag they would be usable when copied)

mercury233 commented 1 year ago

https://www.db.yugioh-card.com/yugiohdb/faq_search.action?ope=5&fid=6264&keyword=&tag=-1&request_locale=ja https://www.db.yugioh-card.com/yugiohdb/faq_search.action?ope=5&fid=15593&keyword=&tag=-1&request_locale=ja

add Card.IsEffectCopied(Effect e) to handle this