search

Flutter-Buddies / tic_tac_no

Complex variants of tic-tac-toe game
MIT License
19 stars 10 forks source link

Locale conjugation #62

Closed FliesWithWind closed 3 years ago

FliesWithWind commented 3 years ago

I've noticed an issue with Polish translation where "won" needs to differ in "You won!" and "AI won!" due to Polish conjugation.

I have added conjugation check for locale and updated winner text.

I'm not sure how many other languages need it (if any), and if it is the best solution, so I'm open to criticism and other solutions. ;)

slovnicki commented 3 years ago

I will review and merge tonight. We definitely need something like this, yes.

slovnicki commented 3 years ago

the discussion will continue at https://github.com/Flutter-Buddies/tic_tac_no/issues/53