GoError: The parent route must be a page route to have a GoRouterState

isegal commented 4 months ago

Has your issue been reported?

[X] I have searched the existing issues and confirm it has not been reported.
[X] I give permission for members of the FlutterFlow team to access and test my project for the sole purpose of investigating this issue.

Current Behavior

The code that is generated for the Global Property -> "Link To Corrent Page does not work when invoked inside a component that is part of a bottom sheet.

The generated code is:

GoRouterState.of(context).uri.toString()

This causes the widget to crash due to the new Go Router breaking changes.

See: https://github.com/flutter/flutter/issues/131154

Manually patching the generated code to the following makes the problem go away:

GoRouter.of(context).getCurrentLocation()

Expected Behavior

It should not crash. The variable should return a link to current page.

Steps to Reproduce

Enable deep linking
Create a component
Create a custom function that takes a string.
Invoke the custom function, and provide the variable as Global Property -> "Link To Corrent Page
Add a bottom sheet that opens the component
Add a button that opens the bottom sheet

Reproducible from Blank

[X] The steps to reproduce above start from a blank project.

Bug Report Code (Required)

IT40hcnfz5Fgod9c1rrUK/lahmU5JlN9RI0Nke57aCgofePtOol3evXsUFBtZMumS2xiMUSmmT4d+d6NiISTG8ABNTidc4hE+qpUEQ6UWl6ha5OBBs2WbX98HZ5hCnXD4bbQsBB4GPB2c1oFw12MGeqQdDLYN7WxImdISq/LZO4=

Context

Before the GoRouter upgrade, there was no crash. Currently it makkes our app not acceptible for production release.

Visual documentation

Additional Info

Have the dev team take a look at the snippets I posted above. It might be a quick fix.

Environment

- FlutterFlow version: Latest
- Platform: all
- Browser name and version: N/A
- Operating system and version affected: all

General

[ ] I was collaborating with other users in the same project prior to data loss
[ ] I navigated between different project views leading up to data loss
[ ] The UI was running very slowly prior to data loss
[ ] A crash or other bug occurred prior to data loss
[ ] Data was not saved in a snapshot
[ ] I was using flutterflow from multiple devices
[ ] I was using flutterflow from multiple platforms (e.g. both web and MacOS Desktop app)

Relative to the time the changes were made, data was lost within

[ ] 1 minute
[ ] 1 hour
[ ] 1 day
[ ] 1 week

When following my steps to reproduce, data loss happens

[ ] ~100% of the time
[ ] ~50% of the time
[ ] ~10% of the time
[ ] ~1% of the time
[ ] Very rarely or only encountered once

ignalauret commented 4 months ago

Hey @isegal thanks for your report. I can confirm that an error occurs when I replicate your steps. Now, I don't know if this is a wrong implementation, and there is another way to do it, or it's an actual bug. I will send this to our technical team so they can clarify the situation, they will keep you updated on this thread. Have a great day!

jazzedge24 commented 4 months ago

I can confirm the issue with an existing application which until the update worked correctly.

jazzedge24 commented 3 months ago

Any indication of when this "unknown" issue might be addressed?

isegal commented 2 weeks ago

@FlutterFlowEng we still see this issue, others have confirmed. Are there any concerns or anything preventing the team to apply the fix?

isegal commented 3 days ago

@FlutterFlowEng we have confirmed that the one-liner works in production.

The code that FF generates appears to be the wrong (old way) to get the URI and can grey-screen in some scenarios:

GoRouterState.of(context).uri.toString()

This is the correct way:

GoRouter.of(context).getCurrentLocation()

It looks like it is using FF-authored code that is intended for this purpose:

extension GoRouterLocationExtension on GoRouter {
  String getCurrentLocation() {
    final RouteMatch lastMatch = routerDelegate.currentConfiguration.last;
    final RouteMatchList matchList = lastMatch is ImperativeRouteMatch
        ? lastMatch.matches
        : routerDelegate.currentConfiguration;
    return matchList.uri.toString();
  }
}

See https://github.com/flutter/flutter/issues/135854

I am hoping that the technical information provided will allow you to apply this fix without spending much effort. It is quite awkward and inefficient for us to locally patch FF-generated code every time.

FlutterFlow / flutterflow-issues