FlutterGen / flutter_gen

The Flutter code generator for your assets, fonts, colors, … — Get rid of all String-based APIs.
https://pub.dev/packages/flutter_gen
MIT License
1.48k stars 150 forks source link

fix: provide theme to SvgAssetLoader instead of SvgPicture #532

Closed Kirpal closed 4 months ago

Kirpal commented 4 months ago

What does this change?

Since version 5.5.0+1, the SvgTheme no longer works. It doesn't work because flutter_svg has deprecated using the theme with the SvgPicture constructor, and suggests that you pass the theme to the bytes loader instead.

Fixes #531 🎯

Type of change

Please delete options that are not relevant.

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.27%. Comparing base (dbc01db) to head (b427a82).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #532 +/- ## ======================================= Coverage 97.27% 97.27% ======================================= Files 22 22 Lines 772 772 ======================================= Hits 751 751 Misses 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.