lunch map sort - Githubissues

FlutterKaigi / conference-app-2023

The Official Conference Application for FlutterKaigi 2023

https://flutterkaigi.jp/conference-app-2023/

Apache License 2.0

133 stars 27 forks source link

lunch map sort #192

Closed HasegawaShuhei closed 1 year ago

HasegawaShuhei commented 1 year ago

Description

Added ascending and descending sorting by id and time required.

Fixes #183

Type of change

[x] New feature

How Has This Been Tested?

Open lunch map page and test like below.

https://github.com/FlutterKaigi/conference-app-2023/assets/77727737/571c9367-9392-473e-8044-4a30c94ff303

Checklist

[x] My code follows the style guidelines of this project.
[x] My code has been formatted with flutter format lib.
[x] My code has been fixed with dart fix --apply lib.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

HasegawaShuhei commented 1 year ago

@koji-1009 レビューお願いします！

HasegawaShuhei commented 1 year ago

@koji-1009 レビューありがとうございます！ご指摘いただいた部分の修正を行ったので、お手隙の際に確認お願いします！

github-actions[bot] commented 1 year ago

Commented by GitHub Bot

PR: #192 preview link