feat: favorite sessions feature (add IconButton & visible in the sessions page) - Githubissues

FlutterKaigi / conference-app-2023

The Official Conference Application for FlutterKaigi 2023

https://flutterkaigi.jp/conference-app-2023/

Apache License 2.0

132 stars 27 forks source link

feat: favorite sessions feature (add IconButton & visible in the sessions page) #194

Closed harusys closed 11 months ago

harusys commented 11 months ago

Description

Add an IconButton to the session details page and add it to favorites when pressed. 6dd5236cb2b8f9ac8846aadec055113a1388d939
- Only session IDs added to favorites are stored in shared_preferences (key: favorite_session_ids).
Make favorites visible in the sessions page 2dba1b9f7b72363ba384a5aa25b40f4a8f73a111

Refs #174

Type of change

[x] New feature

How Has This Been Tested?

Session IDs added to favorites are stored in local storage.
Only sessions added to favorites are filled ❤️ .

favorite_sessions

Checklist

[x] My code follows the style guidelines of this project.
[x] My code has been formatted with flutter format lib.
[x] My code has been fixed with dart fix --apply lib.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

harusys commented 11 months ago

@koji-1009 早速レビューありがとうございます！ご指摘に対応しまして、アイコンボタンの配置については少し悩んでる点があり、ご意見いただけますと幸いです 🙇🏻

github-actions[bot] commented 11 months ago

Commented by GitHub Bot

PR: #194 preview link