style: Move favorites button / Add twitter share button - Githubissues

FlutterKaigi / conference-app-2023

The Official Conference Application for FlutterKaigi 2023

https://flutterkaigi.jp/conference-app-2023/

Apache License 2.0

133 stars 27 forks source link

style: Move favorites button / Add twitter share button #230

Closed harusys closed 1 year ago

harusys commented 1 year ago

Description

Rearrange buttons according to M3 IconButton Placement.
Set tooltip for accessibility.
(Optional) Add twitter share button like FlutterKaigi Web.

Fixes #202

Type of change

[x] Style

How Has This Been Tested?

The behavior of the add favorites button has not changed.
When press the twitter share button, the tweet screen opens in external application.

https://github.com/FlutterKaigi/conference-app-2023/assets/56357240/56ff7c25-c772-41d6-a885-a1103873caae

Checklist

[x] My code follows the style guidelines of this project.
[x] My code has been formatted with flutter format lib.
[x] My code has been fixed with dart fix --apply lib.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

github-actions[bot] commented 1 year ago

Commented by GitHub Bot

PR: #230 preview link