FlutterMatic / desktop

A Flutter desktop manager that helps you setup Flutter, organize, and use workflows with your Flutter projects.
BSD 3-Clause "New" or "Revised" License
10 stars 0 forks source link

[🐛] Markdown doesn't render correctly in pub docs #68

Closed yahu1031 closed 2 years ago

yahu1031 commented 2 years ago

Describe the bug Markdown on pub docs wasn't rendering correctly EG: > and code blocks.

`

This back quote is being converted to >.

Screenshot 2022-02-18 at 12 08 08 AM

Missing some tags (EG: Discord)

This tag gives

════════ Exception caught by SVG ═══════════════════════════════════════════════
The following UnsupportedError was thrown in _Element.svg:
Unsupported operation: Unsupported nested <svg> element.

The root <svg> element contained an unsupported nested SVG element.

Picture key: NetworkPicture("[https://codecov.io/gh/rrousselGit/provider/branch/master/graph/badge.svg]()", headers: null, colorFilter: null)
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by SVG ═══════════════════════════════════════════════
Exception: Invalid image data
════════════════════════════════════════════════════════════════════════════════

Error To Reproduce Steps to reproduce the behavior:

  1. Go to the Pub tab
  2. Click on provider package

Expected behavior It must show the discord tag. Not only discord and some other packages tags were being missed.

Screenshots

Screenshot 2022-02-18 at 12 05 23 AM

Desktop (please complete the following information):

Logs (please upload the logs file by following the instructions): Unable to generate logs

ZiyadF296 commented 2 years ago

This issue is aware of and already noted earlier. It is related to the changelog rendering issue. If that gets solved this gets solved too (same markdown rendering widget)

yahu1031 commented 2 years ago

Duplicate of?

ZiyadF296 commented 2 years ago

50

ZiyadF296 commented 2 years ago

This feature will be removed until there is official API for Pub docs.

yahu1031 commented 2 years ago

But this doesn't come under pub API.

yahu1031 commented 2 years ago

And also, this is not a duplicate of #50. Cause the rendering is very different. EG: .exe was showing in black or dark grey whereas, in docs, it was being converted to > with a new line.

So this is neither a duplicate nor a pub docs API issue.

ZiyadF296 commented 2 years ago

This issue will not be worked on as this docs feature for pub is removed until there is an official API for it.

yahu1031 commented 2 years ago

Make it backlogged. Don't close it.

ZiyadF296 commented 2 years ago

This feature NO LONGER EXISTS. It's gone forever until there is a docs feature in the future. Until then, this issue is closed. If there is a problem then please open it in a different issue. This issue please shall please remain closed.

yahu1031 commented 2 years ago

That is why I backlogged and triaged it.

ZiyadF296 commented 2 years ago

The feature won't come back anytime soon. And when it comes back, this issue will no longer be needed. I am aware of the docs rendering issue, it is not our issue, it is a dependency we are using that renders markdown. So facing the truth, it should be filed in their GitHub repo, not this repo.

As a sign of respect, please don't re-open this issue after this. Any bugs or errors reference them in new tickets, sincerely.

yahu1031 commented 2 years ago

Remove the click functionality in the next commit and then I will review and close it.

ZiyadF296 commented 2 years ago

It has already been removed. Push is pending.

ZiyadF296 commented 2 years ago

Please review and close. Thanks 😊

yahu1031 commented 2 years ago

Checked and verified.